coveralls
commented
3 weeks ago Pull Request Test Coverage Report for Build 018fe9e0-42b0-480c-8dab-bca19aed9094
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- 151 unchanged lines in 14 files lost coverage.
- Overall coverage decreased (-0.08%) to 70.654%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| common/backoff/retry.go | 2 | 92.11% | ||
| common/task/fifo_task_scheduler.go | 2 | 85.57% | ||
| service/history/task/transfer_active_task_executor.go | 2 | 72.77% | ||
| common/persistence/historyManager.go | 2 | 66.67% | ||
| service/history/task/task.go | 3 | 84.81% | ||
| service/matching/tasklist/task_list_manager.go | 3 | 75.89% | ||
| bench/lib/client.go | 4 | 0.0% | ||
| service/matching/config/config.go | 4 | 91.49% | ||
| service/history/task/fetcher.go | 4 | 85.05% | ||
| <!-- | Total: | 151 | --> |
| Totals | |
|---|---|
| Change from base Build 018fe9dc-483b-4c68-acea-8033170f8941: | -0.08% |
| Covered Lines: | 105240 |
| Relevant Lines: | 148951 |
Also renamed variable as
rlooks too short and stands more for reader or ref rather than response/result.comment to make more obvious since we talk about "send on closed channel" error here
Refactoring during deep dive session
How did you test it?
Potential risks
Release notes
Documentation Changes