uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Added tests for common/blobstore/retryableClient.go #6111

Closed agautam478 closed 3 weeks ago

agautam478 commented 3 weeks ago

What changed? Added tests for the common/blobstore/retryableClient.go

Why? code coverage

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.52%. Comparing base (294a120) to head (bcf1471).

:exclamation: Current head bcf1471 differs from pull request most recent head cfa1fca

Please upload reports for the commit cfa1fca to get more accurate results.

Additional details and impacted files [see 6 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6111/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6111?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6111?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [294a120...cfa1fca](https://app.codecov.io/gh/uber/cadence/pull/6111?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fea1b-bc74-46bc-9a77-44b66204fb65

Details


Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 87.14%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_active_task_executor.go 2 72.77%
service/history/execution/mutable_state_util.go 2 78.52%
service/matching/tasklist/matcher.go 2 89.35%
service/matching/tasklist/task_reader.go 2 75.33%
common/task/fifo_task_scheduler.go 4 83.51%
service/matching/tasklist/task_list_manager.go 7 76.05%
<!-- Total: 23 -->
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.04%
Covered Lines: 105511
Relevant Lines: 148942

πŸ’› - Coveralls
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fea42-4f79-4e0c-8d5e-77958ecfaeb2

Details


Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/matching/tasklist/task_reader.go 2 77.72%
service/history/handler/handler.go 3 96.2%
common/persistence/statsComputer.go 3 98.21%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 6 86.33%
<!-- Total: 24 -->
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.06%
Covered Lines: 105549
Relevant Lines: 148942

πŸ’› - Coveralls