search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Write more tests for replication task processor #6112

Closed taylanisikdemir closed 3 weeks ago

taylanisikdemir commented 3 weeks ago

What changed? Added tests for replication/task_processor.go

Why? Improve coverage

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.58%. Comparing base (b38bd0c) to head (92ca080). Report is 14 commits behind head on master.

Additional details and impacted files [see 17 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6112/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6112?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6112?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [b38bd0c...92ca080](https://app.codecov.io/gh/uber/cadence/pull/6112?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fea4d-ed78-495f-8ed2-c45333c2d157

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/config/config.go 0 6 0.0%
<!-- Total: 0 6 0.0% -->
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
service/history/task/transfer_active_task_executor.go 2 72.77%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/statsComputer.go 3 98.21%
bench/lib/client.go 4 0.0%
service/matching/config/config.go 4 91.49%
service/history/task/fetcher.go 4 86.08%
service/history/task/transfer_standby_task_executor.go 6 86.94%
<!-- Total: 402 -->
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: -0.1%
Covered Lines: 105286
Relevant Lines: 148958
💛 - Coveralls