coveralls
commented
3 weeks ago Pull Request Test Coverage Report for Build 018fea2a-9ba1-4126-9c6e-43ee4e57e834
Details
- 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
- 30 unchanged lines in 6 files lost coverage.
- Overall coverage increased (+0.01%) to 70.812%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| common/membership/hashring.go | 2 | 84.69% | ||
| service/matching/tasklist/matcher.go | 2 | 89.35% | ||
| service/matching/tasklist/task_reader.go | 2 | 75.33% | ||
| service/history/task/transfer_standby_task_executor.go | 6 | 87.35% | ||
| service/matching/tasklist/task_list_manager.go | 16 | 76.28% | ||
| <!-- | Total: | 30 | --> |
| Totals | |
|---|---|
| Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: | 0.01% |
| Covered Lines: | 105472 |
| Relevant Lines: | 148947 |
a) taskList is misleading as we're retrieving taskList itself later in some functions. b) consistency: some functinos of the file already use tasklistID for the same purpose.
renamed taskList -> taskListID because of the above reasons
refactoring during deep dive session
How did you test it?
Potential risks
Release notes
Documentation Changes