uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Include Domain in GRPC UpdateDomainIsolationGroupsRequest #6114

Closed natemort closed 3 weeks ago

natemort commented 3 weeks ago

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.88%. Comparing base (6847c33) to head (00c36bf). Report is 9 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6114?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/types/mapper/proto/admin.go](https://app.codecov.io/gh/uber/cadence/pull/6114?src=pr&el=tree&filepath=common%2Ftypes%2Fmapper%2Fproto%2Fadmin.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3R5cGVzL21hcHBlci9wcm90by9hZG1pbi5nbw==) | `99.76% <100.00%> (+30.68%)` | :arrow_up: | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6114?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6114?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [6847c33...00c36bf](https://app.codecov.io/gh/uber/cadence/pull/6114?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fea45-352e-4468-9978-57274eb4f684

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/execution/mutable_state_util.go 2 78.52%
common/membership/hashring.go 2 84.69%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/statsComputer.go 3 98.21%
bench/lib/client.go 4 0.0%
service/history/task/transfer_standby_task_executor.go 6 86.33%
common/domain/replication_queue.go 18 74.83%
service/history/task/task_util.go 20 70.57%
service/frontend/api/handler.go 92 66.17%
<!-- Total: 408 -->
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.2%
Covered Lines: 105743
Relevant Lines: 148947

💛 - Coveralls