uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Update coverage exclusions #6115

Closed taylanisikdemir closed 3 weeks ago

taylanisikdemir commented 3 weeks ago

What changed?

Why? Improve coverage accuracy

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.93%. Comparing base (294a120) to head (0cb2670). Report is 1 commits behind head on master.

:exclamation: Current head 0cb2670 differs from pull request most recent head 36ff81e

Please upload reports for the commit 36ff81e to get more accurate results.

Additional details and impacted files [see 12 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6115/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6115?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6115?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [294a120...36ff81e](https://app.codecov.io/gh/uber/cadence/pull/6115?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 018fea5f-0e39-40b3-aa6d-5d7e6d72c31a

Details


Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
service/matching/tasklist/task_list_manager.go 2 77.05%
common/persistence/statsComputer.go 3 98.21%
service/history/task/transfer_standby_task_executor.go 6 86.33%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 018fea0f-14e3-4984-94e0-5d6d068277b1: 0.01%
Covered Lines: 105470
Relevant Lines: 148942

💛 - Coveralls