codecov[bot]
commented
2 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.18%. Comparing base (
080dec9) to head (6b794c7).
Closed bowenxia closed 2 weeks ago
codecov[bot]
commented
2 weeks ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.18%. Comparing base (
080dec9) to head (6b794c7).
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| common/task/parallel_task_processor.go | 2 | 93.06% | ||
| service/history/task/transfer_standby_task_executor.go | 3 | 86.33% | ||
| service/history/task/task.go | 3 | 84.81% | ||
| service/history/queue/timer_queue_processor_base.go | 4 | 77.66% | ||
| service/matching/tasklist/task_list_manager.go | 5 | 76.05% | ||
| service/history/execution/cache.go | 6 | 74.61% | ||
| service/history/task/fetcher.go | 6 | 85.05% | ||
| service/history/task/cross_cluster_task_processor.go | 8 | 80.79% | ||
| service/history/task/task_util.go | 20 | 70.57% | ||
| <!-- | Total: | 59 | --> |
| Totals | |
|---|---|
| Change from base Build 018ff521-a453-4f25-a2e8-6d1d59e59c06: | -0.03% |
| Covered Lines: | 106455 |
| Relevant Lines: | 149096 |
What changed? When memo.data is empty, add a logic to set the entire memo to be nil, and then add it to pinot response.
Why? To fix memo deserialization error in mono repo. Previously, when data is empty it was still added to in the response, so in the visibility_single_manager, it will cause a deserialization error when it is trying to deserialize memo.
How did you test it? unit test
Potential risks
Release notes
Documentation Changes