Closed Groxx closed 2 weeks ago
codecov[bot]
commented
2 weeks ago Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
Project coverage is 72.21%. Comparing base (
080dec9) to head (d2f6889). Report is 5 commits behind head on master.
coveralls
commented
2 weeks ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| service/matching/tasklist/matcher.go | 6 | 12 | 50.0% | ||
| <!-- | Total: | 17 | 23 | 73.91% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| service/history/task/fetcher.go | 2 | 85.57% | ||
| service/history/task/transfer_standby_task_executor.go | 3 | 86.33% | ||
| service/history/task/task.go | 3 | 84.81% | ||
| common/task/fifo_task_scheduler.go | 3 | 82.47% | ||
| service/history/queue/timer_queue_processor_base.go | 4 | 77.66% | ||
| service/matching/tasklist/matcher.go | 4 | 88.04% | ||
| service/matching/tasklist/task_list_manager.go | 5 | 76.05% | ||
| service/history/execution/cache.go | 6 | 74.61% | ||
| service/history/task/cross_cluster_task_processor.go | 8 | 80.79% | ||
| <!-- | Total: | 40 | --> |
| Totals | |
|---|---|
| Change from base Build 018ff521-a453-4f25-a2e8-6d1d59e59c06: | -0.01% |
| Covered Lines: | 106456 |
| Relevant Lines: | 149076 |
coveralls
commented
2 weeks ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| service/matching/tasklist/matcher.go | 7 | 13 | 53.85% | ||
| <!-- | Total: | 18 | 24 | 75.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| service/matching/tasklist/task_reader.go | 2 | 77.72% | ||
| service/history/queue/timer_queue_processor_base.go | 3 | 77.87% | ||
| service/matching/tasklist/task_list_manager.go | 5 | 76.45% | ||
| service/matching/tasklist/matcher.go | 6 | 87.27% | ||
| <!-- | Total: | 18 | --> |
| Totals | |
|---|---|
| Change from base Build 018ff521-a453-4f25-a2e8-6d1d59e59c06: | 0.02% |
| Covered Lines: | 106500 |
| Relevant Lines: | 149075 |
coveralls
commented
2 weeks ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
| common/peerprovider/ringpopprovider/config.go | 2 | 81.58% | ||
| tools/cli/admin_db_decode_thrift.go | 2 | 70.51% | ||
| service/frontend/api/handler.go | 2 | 75.6% | ||
| service/history/queue/timer_queue_processor_base.go | 3 | 77.87% | ||
| common/archiver/filestore/historyArchiver.go | 4 | 80.95% | ||
| service/matching/tasklist/task_list_manager.go | 5 | 76.05% | ||
| <!-- | Total: | 20 | --> |
| Totals | |
|---|---|
| Change from base Build 018ff521-a453-4f25-a2e8-6d1d59e59c06: | 0.01% |
| Covered Lines: | 106500 |
| Relevant Lines: | 149081 |
Partly this is worth doing at some point regardless, and partly this is a bit of a blocker for the global ratelimiter, as it needs to expose some Reservation-using APIs to fit into existing ratelimiter code.
This has a larger blast-radius than I'd like, as it's not just frontend, but it should be safe - the clock.Ratelimiter is pretty thoroughly tested, and the small changes in behavior seem in line with what the code around it expects to happen, rather than what actually happens.