Closed natemort closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.17%. Comparing base (
50dce23
) to head (c1d7953
).
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% | ||
common/task/fifo_task_scheduler.go | 2 | 83.51% | ||
service/frontend/api/handler.go | 2 | 75.6% | ||
common/util.go | 2 | 91.84% | ||
common/persistence/historyManager.go | 2 | 66.67% | ||
common/persistence/statsComputer.go | 3 | 98.21% | ||
common/archiver/filestore/historyArchiver.go | 4 | 80.95% | ||
service/matching/tasklist/task_list_manager.go | 4 | 76.65% | ||
service/history/task/task_util.go | 20 | 70.57% | ||
<!-- | Total: | 41 | --> |
Totals | |
---|---|
Change from base Build 01900690-d484-497f-aa13-7290075d24d1: | 0.0% |
Covered Lines: | 106486 |
Relevant Lines: | 149101 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
common/task/weighted_round_robin_task_scheduler.go | 2 | 88.06% | ||
common/peerprovider/ringpopprovider/config.go | 2 | 81.58% | ||
service/matching/tasklist/task_list_manager.go | 2 | 77.05% | ||
service/history/task/transfer_active_task_executor.go | 2 | 72.77% | ||
service/history/task/fetcher.go | 2 | 85.05% | ||
common/persistence/historyManager.go | 2 | 66.67% | ||
service/history/handler/handler.go | 3 | 96.2% | ||
common/persistence/statsComputer.go | 3 | 98.21% | ||
service/history/task/cross_cluster_task_processor.go | 8 | 80.79% | ||
service/history/task/task_util.go | 20 | 70.57% | ||
<!-- | Total: | 46 | --> |
Totals | |
---|---|
Change from base Build 01900690-d484-497f-aa13-7290075d24d1: | -0.02% |
Covered Lines: | 106463 |
Relevant Lines: | 149103 |
With client retries we could end up with multiple messages for the same workflow id, particularly for the Java client which doesn't correctly reuse the same request ID across retries. We should treat a WorkflowExecutionAlreadyStartedError as a success indicator to support at-most once execution of a workflow.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes