uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Add tests for service/history/execution/mutable_state_task_generator.go #6129

Closed fimanishi closed 2 weeks ago

fimanishi commented 2 weeks ago

What changed? tests for service/history/execution/mutable_state_task_generator.go

Why? improve unit test coverage

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.33%. Comparing base (b25960e) to head (ced7075). Report is 15 commits behind head on master.

Additional details and impacted files [see 27 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6129/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6129?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Ξ” = absolute (impact)`, `ΓΈ = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6129?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [b25960e...ced7075](https://app.codecov.io/gh/uber/cadence/pull/6129?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 0190097e-921e-4e70-a0ca-546e784395ff

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/parallel_task_processor.go 2 93.06%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.77%
common/util.go 2 91.84%
service/frontend/wrappers/accesscontrolled/access_controlled.go 2 88.46%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/task.go 3 84.81%
service/history/handler/handler.go 3 96.2%
service/history/task/fetcher.go 3 86.6%
<!-- Total: 377 -->
Totals Coverage Status
Change from base Build 019008cc-dc35-4c24-a6bc-044c76fa1f43: -0.2%
Covered Lines: 106112
Relevant Lines: 148957

πŸ’› - Coveralls
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 019012da-4a77-44e9-9ef4-cb3a66339bee

Details


Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.28%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/frontend/wrappers/accesscontrolled/access_controlled.go 2 88.46%
service/history/execution/mutable_state_builder.go 2 78.45%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
<!-- Total: 385 -->
Totals Coverage Status
Change from base Build 019008cc-dc35-4c24-a6bc-044c76fa1f43: -0.2%
Covered Lines: 106094
Relevant Lines: 148957

πŸ’› - Coveralls