search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Allow custom sorting in ListAllWorkflowExecutions api #6130

Closed sankari165 closed 2 weeks ago

sankari165 commented 2 weeks ago

What changed? Sorting was by default set to StartTime in Descending Order. This PR enables custom sorting

Why? It would help to provide this as feature enhancement in cadence-web v4

How did you test it? unit tests

Potential risks Fallback to default behaviour prevents risk

Release notes

Documentation Changes

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.21%. Comparing base (ecb93a1) to head (037fb7a).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6130?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [...mon/persistence/dataVisibilityManagerInterfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=common%2Fpersistence%2FdataVisibilityManagerInterfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFWaXNpYmlsaXR5TWFuYWdlckludGVyZmFjZXMuZ28=) | `0.00% <ø> (ø)` | | | [common/persistence/data\_store\_interfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=common%2Fpersistence%2Fdata_store_interfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFfc3RvcmVfaW50ZXJmYWNlcy5nbw==) | `100.00% <ø> (ø)` | | | [common/persistence/pinot/pinot\_visibility\_store.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=common%2Fpersistence%2Fpinot%2Fpinot_visibility_store.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Bpbm90L3Bpbm90X3Zpc2liaWxpdHlfc3RvcmUuZ28=) | `93.05% <100.00%> (+0.07%)` | :arrow_up: | | [common/persistence/visibility\_single\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=common%2Fpersistence%2Fvisibility_single_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Zpc2liaWxpdHlfc2luZ2xlX21hbmFnZXIuZ28=) | `99.22% <100.00%> (+<0.01%)` | :arrow_up: | | [service/frontend/api/handler.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=service%2Ffrontend%2Fapi%2Fhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9mcm9udGVuZC9hcGkvaGFuZGxlci5nbw==) | `65.26% <100.00%> (+0.02%)` | :arrow_up: | | [common/pinot/pinotQueryValidator.go](https://app.codecov.io/gh/uber/cadence/pull/6130?src=pr&el=tree&filepath=common%2Fpinot%2FpinotQueryValidator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3Bpbm90L3Bpbm90UXVlcnlWYWxpZGF0b3IuZ28=) | `84.88% <66.66%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6130/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6130?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6130?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [ecb93a1...037fb7a](https://app.codecov.io/gh/uber/cadence/pull/6130?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 01900c58-a5ef-4b78-8a4f-a7788a35b53d

Details

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/util.go 2 91.84%
service/history/execution/mutable_state_builder.go 2 78.45%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 50.46%
service/history/task/fetcher.go 3 86.6%
<!-- Total: 59 -->
Totals Coverage Status
Change from base Build 019008cc-dc35-4c24-a6bc-044c76fa1f43: 0.01%
Covered Lines: 106532
Relevant Lines: 149110
💛 - Coveralls