uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

[history] Make large_history_size_count tagged by domain #6131

Closed 3vilhamster closed 2 weeks ago

3vilhamster commented 2 weeks ago

What changed? Metrics for large history blob/size/count are now tagged by the domain name.

Why? These metrics can be used to inform customers about reaching limitations for decision tasks per workflow before they reach the limit and their workflow fails.

How did you test it? Added test to verify metrics emission.

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.21%. Comparing base (10969a0) to head (67d32db).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6131?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/history/execution/context\_util.go](https://app.codecov.io/gh/uber/cadence/pull/6131?src=pr&el=tree&filepath=service%2Fhistory%2Fexecution%2Fcontext_util.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9oaXN0b3J5L2V4ZWN1dGlvbi9jb250ZXh0X3V0aWwuZ28=) | `38.53% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6131/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6131?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6131?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [10969a0...67d32db](https://app.codecov.io/gh/uber/cadence/pull/6131?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 01900cfd-03d5-4048-86ad-41b4de7078d4

Details


Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_standby_task_executor.go 2 86.94%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/cache/lru.go 2 93.01%
service/matching/tasklist/task_list_manager.go 2 76.45%
common/task/fifo_task_scheduler.go 2 87.63%
service/history/execution/mutable_state_builder.go 2 78.45%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/statsComputer.go 3 98.21%
<!-- Total: 20 -->
Totals Coverage Status
Change from base Build 01900c81-1065-45f0-94c0-6a0af9238cdc: 0.03%
Covered Lines: 106553
Relevant Lines: 149110

💛 - Coveralls