search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Allow filtering by CloseStatus in ListAllWorkflowExecutions api #6133

Closed sankari165 closed 2 weeks ago

sankari165 commented 2 weeks ago

What changed? Filtering by a list of closestatus in listallworkflowexecutions api.

Why? So webv4 can make it possible to filter on workflow status

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.22%. Comparing base (bf8cb36) to head (bfa10b1).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6133?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [...mon/persistence/dataVisibilityManagerInterfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6133?src=pr&el=tree&filepath=common%2Fpersistence%2FdataVisibilityManagerInterfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFWaXNpYmlsaXR5TWFuYWdlckludGVyZmFjZXMuZ28=) | `0.00% <ø> (ø)` | | | [common/persistence/data\_store\_interfaces.go](https://app.codecov.io/gh/uber/cadence/pull/6133?src=pr&el=tree&filepath=common%2Fpersistence%2Fdata_store_interfaces.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL2RhdGFfc3RvcmVfaW50ZXJmYWNlcy5nbw==) | `100.00% <ø> (ø)` | | | [common/persistence/pinot/pinot\_visibility\_store.go](https://app.codecov.io/gh/uber/cadence/pull/6133?src=pr&el=tree&filepath=common%2Fpersistence%2Fpinot%2Fpinot_visibility_store.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Bpbm90L3Bpbm90X3Zpc2liaWxpdHlfc3RvcmUuZ28=) | `93.15% <100.00%> (+0.09%)` | :arrow_up: | | [common/persistence/visibility\_single\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6133?src=pr&el=tree&filepath=common%2Fpersistence%2Fvisibility_single_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3BlcnNpc3RlbmNlL3Zpc2liaWxpdHlfc2luZ2xlX21hbmFnZXIuZ28=) | `99.22% <100.00%> (+<0.01%)` | :arrow_up: | | [service/frontend/api/handler.go](https://app.codecov.io/gh/uber/cadence/pull/6133?src=pr&el=tree&filepath=service%2Ffrontend%2Fapi%2Fhandler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9mcm9udGVuZC9hcGkvaGFuZGxlci5nbw==) | `65.27% <100.00%> (+0.01%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6133/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6133?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6133?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [bf8cb36...bfa10b1](https://app.codecov.io/gh/uber/cadence/pull/6133?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 0190129f-33c2-48ec-927f-cb7cb1309a3d

Details

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/cache/lru.go 2 93.01%
service/history/queue/transfer_queue_processor.go 2 56.49%
service/matching/tasklist/matcher.go 2 90.91%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/persistence/statsComputer.go 3 98.21%
<!-- Total: 14 -->
Totals Coverage Status
Change from base Build 01901178-520a-4ecd-8c17-3722bda71894: 0.02%
Covered Lines: 106569
Relevant Lines: 149123
💛 - Coveralls