uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Bump docker/build-push-action to v5 #6134

Closed mantas-sidlauskas closed 1 week ago

mantas-sidlauskas commented 2 weeks ago

What changed? Upgrading action to v5 to support platforms setting.

Why? This is follow up for https://github.com/uber/cadence/pull/5962.

Current action is reporting this warning: Warning: Unexpected input(s) 'platforms', valid inputs are ['entryPoint', 'args', 'username', 'password', 'registry', 'repository', 'tags', 'tag_with_ref', 'tag_with_sha', 'path', 'dockerfile', 'target', 'always_pull', 'build_args', 'cache_froms', 'labels', 'add_git_labels', 'push']

How did you test it?

Potential risks

Release notes

Documentation Changes

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 019015ce-3cf3-48fd-9167-b093d31005ba

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/frontend/api/handler.go 2 75.62%
service/history/task/transfer_active_task_executor.go 2 72.77%
service/history/task/task.go 3 84.81%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/execution/cache.go 6 74.61%
service/history/task/transfer_standby_task_executor.go 9 85.92%
service/history/task/task_util.go 20 70.57%
<!-- Total: 47 -->
Totals Coverage Status
Change from base Build 01901361-90ee-4e3d-a3a8-878ba8676db2: -0.02%
Covered Lines: 106512
Relevant Lines: 149108

💛 - Coveralls
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.34%. Comparing base (bf8cb36) to head (a7e37a4). Report is 4 commits behind head on master.

Additional details and impacted files [see 6 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6134?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6134?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [bf8cb36...a7e37a4](https://app.codecov.io/gh/uber/cadence/pull/6134?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).