uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.96k stars 772 forks source link

Added internal count metrics in addition to the external counts that are already there #6135

Closed jakobht closed 2 weeks ago

jakobht commented 2 weeks ago

What changed? Added new metric which gives the max per workflow ID rps we have seen for the domain every second

Why? This will help users understand how close they are to the per workflow ID rate limits

How did you test it? Unit tests

Potential risks Just adding a metric, so should be safe

Release notes

Documentation Changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.33%. Comparing base (ceff8ca) to head (c40121a).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6135?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/history/workflowcache/cache.go](https://app.codecov.io/gh/uber/cadence/pull/6135?src=pr&el=tree&filepath=service%2Fhistory%2Fworkflowcache%2Fcache.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9oaXN0b3J5L3dvcmtmbG93Y2FjaGUvY2FjaGUuZ28=) | `92.04% <100.00%> (+0.09%)` | :arrow_up: | | [service/history/workflowcache/metrics.go](https://app.codecov.io/gh/uber/cadence/pull/6135?src=pr&el=tree&filepath=service%2Fhistory%2Fworkflowcache%2Fmetrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9oaXN0b3J5L3dvcmtmbG93Y2FjaGUvbWV0cmljcy5nbw==) | `100.00% <100.00%> (ø)` | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6135/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6135?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6135?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [ceff8ca...c40121a](https://app.codecov.io/gh/uber/cadence/pull/6135?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).
coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 019016b9-e5ea-4b5a-8890-ee47b7718219

Details


Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.66%
service/history/task/transfer_standby_task_executor.go 2 86.33%
service/matching/tasklist/task_list_manager.go 2 76.05%
common/util.go 2 91.84%
service/history/handler/handler.go 3 96.2%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 0190167e-35fa-415a-84db-56b7e95361ae: 0.01%
Covered Lines: 106527
Relevant Lines: 149124

💛 - Coveralls