Closed fimanishi closed 1 week ago
codecov[bot]
commented
2 weeks ago Attention: Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.
Project coverage is 72.58%. Comparing base (
ecb93a1) to head (bd3ae7c). Report is 7 commits behind head on master.
coveralls
commented
2 weeks ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| common/domain/handler.go | 73 | 83 | 87.95% | ||
| <!-- | Total: | 73 | 83 | 87.95% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| common/task/weighted_round_robin_task_scheduler.go | 2 | 88.06% | ||
| common/persistence/sql/sqlplugin/postgres/task.go | 2 | 73.4% | ||
| service/matching/tasklist/db.go | 2 | 73.23% | ||
| common/quotas/multistageratelimiter.go | 2 | 83.33% | ||
| common/task/fifo_task_scheduler.go | 2 | 87.63% | ||
| common/persistence/visibility_single_manager.go | 2 | 99.36% | ||
| common/log/tag/tags.go | 3 | 50.46% | ||
| service/history/task/fetcher.go | 4 | 85.05% | ||
| service/history/task/transfer_standby_task_executor.go | 5 | 86.33% | ||
| service/history/workflowcache/cache.go | 6 | 93.33% | ||
| <!-- | Total: | 941 | --> |
| Totals | |
|---|---|
| Change from base Build 01901736-46e3-4d50-830b-93f72c960f94: | 0.03% |
| Covered Lines: | 106581 |
| Relevant Lines: | 149129 |
What changed? tests for UpdateDomain in common/domain/handler.go. Created helper methods to make tests easier
Why? improve unit test coverage
How did you test it? unit tests. Test code was verified against the code with and without the helper methods. Also asserted the value of the parameters being passed to the mock methods (and that persist the update) to ensure that variables are being updated correctly. Tested graceful failover locally.
Potential risks The logic didn't change but parts of it were encapsulated in helper methods. Need to ensure that the logic wasn't affected by the changes
Release notes
Documentation Changes