uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.98k stars 775 forks source link

Ensure PR description contains compatibility info & rollout plan when DB schema is changed #6150

Closed taylanisikdemir closed 3 days ago

taylanisikdemir commented 4 days ago

What changed? Adding a new github workflow to run on schema changes and fails if the PR template is missing critical information.

Why? To warn the developer about potential breaking changes.

How did you test it? Made some changes under schema/ folder and validated the new github workflow fails. See screenshot:

Screenshot 2024-07-01 at 12 08 33 PM
coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 01906f63-55bd-433b-bb88-db8bfd7cbb54

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/matching/tasklist/db.go 2 73.23%
common/task/fifo_task_scheduler.go 2 85.57%
service/matching/tasklist/matcher.go 2 90.91%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 49.64%
common/persistence/statsComputer.go 3 98.18%
service/history/task/transfer_standby_task_executor.go 5 86.64%
service/matching/tasklist/task_list_manager.go 5 76.45%
<!-- Total: 52 -->
Totals Coverage Status
Change from base Build 019060e3-e556-4061-8a61-c080801be36f: -0.02%
Covered Lines: 105296
Relevant Lines: 147252

💛 - Coveralls