coveralls
commented
3 days ago Pull Request Test Coverage Report for Build 019070d4-f837-4f0d-bc9f-a372952d8109
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- 56 unchanged lines in 17 files lost coverage.
- Overall coverage decreased (-0.03%) to 71.494%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| service/history/queue/timer_queue_processor_base.go | 1 | 77.66% | ||
| common/task/weighted_round_robin_task_scheduler.go | 2 | 88.56% | ||
| service/matching/tasklist/db.go | 2 | 73.23% | ||
| common/peerprovider/ringpopprovider/config.go | 2 | 81.58% | ||
| common/persistence/sql/sqlplugin/mysql/task.go | 2 | 73.68% | ||
| tools/cli/admin_db_decode_thrift.go | 2 | 70.51% | ||
| service/matching/tasklist/matcher.go | 2 | 90.91% | ||
| common/persistence/sql/sqlplugin/mysql/db.go | 2 | 79.49% | ||
| service/history/task/transfer_standby_task_executor.go | 3 | 87.45% | ||
| service/history/task/task.go | 3 | 84.81% | ||
| <!-- | Total: | 56 | --> |
| Totals | |
|---|---|
| Change from base Build 0190705f-c927-4d1b-b54d-772b615f64e2: | -0.03% |
| Covered Lines: | 105277 |
| Relevant Lines: | 147252 |
This logic desperately needs to be refactored, it's incredibly error-prone :\ We should probably just use enumer's codegen tbh. Or something similar.
Previously
String()missed bothworkflowTypeandratelimitKey. TheString()impl is now rewritten so it won't be missed with future additions, and there's a test to check it too.