uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
7.98k stars 775 forks source link

Include a zero bucket, zeros are being reported as 1 #6153

Closed Groxx closed 2 days ago

Groxx commented 2 days ago

With a min bucket of 1, a 0 is reported as a 1, which is quite misleading for this kind of use.

Sorta obvious in retrospect, but we have so few histograms anywhere that I apparently don't have any safe habits built up.

coveralls commented 2 days ago

Pull Request Test Coverage Report for Build 019074a7-be79-43e7-b97d-7674d472b3a6

Details


Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/task_list_manager.go 2 77.05%
service/frontend/api/handler.go 2 75.62%
service/history/task/transfer_standby_task_executor.go 3 86.23%
service/history/task/task.go 3 84.81%
common/persistence/nosql/nosql_task_store.go 3 85.52%
common/task/fifo_task_scheduler.go 3 84.54%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/execution/cache.go 6 74.61%
service/history/task/task_util.go 20 60.29%
<!-- Total: 48 -->
Totals Coverage Status
Change from base Build 01907465-3a13-43f8-89cc-21fc60d6d529: -0.02%
Covered Lines: 105293
Relevant Lines: 147252

💛 - Coveralls