search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 792 forks source link

Add "is_primary" tag to show the ratelimiter type that's currently in use #6170

Closed Groxx closed 2 months ago

Groxx commented 2 months ago

At the moment it's hard to build monitoring on top of things, because there isn't an easy way to see when a request is rejected in the "real" ratelimiter, vs one that's simply shadowing.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.67%. Comparing base (8664922) to head (5ae4102).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6170?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/quotas/global/collection/collection.go](https://app.codecov.io/gh/uber/cadence/pull/6170?src=pr&el=tree&filepath=common%2Fquotas%2Fglobal%2Fcollection%2Fcollection.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3F1b3Rhcy9nbG9iYWwvY29sbGVjdGlvbi9jb2xsZWN0aW9uLmdv) | `83.93% <100.00%> (+1.25%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6170?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6170?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [8664922...5ae4102](https://app.codecov.io/gh/uber/cadence/pull/6170?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).