search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 792 forks source link

Add global-ratelimiter aggregator-side metrics #6171

Closed Groxx closed 2 months ago

Groxx commented 2 months ago

It would've been useful to have some of these while checking the initial rollout and troubleshooting, and the rest seem possibly-also-useful and easy to collect.

I've also adjusted the histogram buckets shared by other global ratelimiter stuff - nothing is planned that will be actually sensitive to the values, so this should be harmless. It's more for general "wait why do we have 100x more/fewer than we expected"-style discoveries.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.76%. Comparing base (8664922) to head (39c4a12). Report is 6 commits behind head on master.

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6171?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [common/quotas/global/algorithm/requestweighted.go](https://app.codecov.io/gh/uber/cadence/pull/6171?src=pr&el=tree&filepath=common%2Fquotas%2Fglobal%2Falgorithm%2Frequestweighted.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3F1b3Rhcy9nbG9iYWwvYWxnb3JpdGhtL3JlcXVlc3R3ZWlnaHRlZC5nbw==) | `95.55% <100.00%> (+1.07%)` | :arrow_up: | | [common/quotas/global/collection/collection.go](https://app.codecov.io/gh/uber/cadence/pull/6171?src=pr&el=tree&filepath=common%2Fquotas%2Fglobal%2Fcollection%2Fcollection.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3F1b3Rhcy9nbG9iYWwvY29sbGVjdGlvbi9jb2xsZWN0aW9uLmdv) | `84.02% <100.00%> (+1.33%)` | :arrow_up: | | [common/quotas/global/rpc/client.go](https://app.codecov.io/gh/uber/cadence/pull/6171?src=pr&el=tree&filepath=common%2Fquotas%2Fglobal%2Frpc%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-Y29tbW9uL3F1b3Rhcy9nbG9iYWwvcnBjL2NsaWVudC5nbw==) | `76.19% <100.00%> (ø)` | | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6171/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6171?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6171?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [8664922...39c4a12](https://app.codecov.io/gh/uber/cadence/pull/6171?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).