search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 792 forks source link

Add more metrics to async task dispatch #6202

Closed Shaddoll closed 2 months ago

Shaddoll commented 2 months ago

What changed? Add more metrics to async task dispatch

Why? Improve observability

How did you test it? manual tests

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (9a7a8a4) to head (3544e2d). Report is 2 commits behind head on master.

Files Patch % Lines
service/matching/tasklist/matcher.go 80.00% 3 Missing :warning:
Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6202?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/matching/tasklist/matcher.go](https://app.codecov.io/gh/uber/cadence/pull/6202?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Fmatcher.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC9tYXRjaGVyLmdv) | `82.15% <80.00%> (-0.23%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6202?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6202?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [9a7a8a4...3544e2d](https://app.codecov.io/gh/uber/cadence/pull/6202?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).