search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 792 forks source link

Add metrics for matcher #6207

Closed Shaddoll closed 2 months ago

Shaddoll commented 2 months ago

What changed? Add metrics for matcher

Why? improve observability

How did you test it?

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (06e5a6d) to head (df1f885). Report is 1 commits behind head on master.

Files Patch % Lines
service/matching/tasklist/matcher.go 83.33% 3 Missing :warning:
service/matching/tasklist/task_list_manager.go 0.00% 1 Missing :warning:
Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6207?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [service/matching/tasklist/task\_list\_manager.go](https://app.codecov.io/gh/uber/cadence/pull/6207?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Ftask_list_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC90YXNrX2xpc3RfbWFuYWdlci5nbw==) | `66.91% <0.00%> (ø)` | | | [service/matching/tasklist/matcher.go](https://app.codecov.io/gh/uber/cadence/pull/6207?src=pr&el=tree&filepath=service%2Fmatching%2Ftasklist%2Fmatcher.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS9tYXRjaGluZy90YXNrbGlzdC9tYXRjaGVyLmdv) | `78.80% <83.33%> (+0.19%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6207/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6207?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6207?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [06e5a6d...df1f885](https://app.codecov.io/gh/uber/cadence/pull/6207?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).