search

uber / cadence

Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.
https://cadenceworkflow.io
MIT License
8.22k stars 792 forks source link

Debug es-analyzer II: CadenceChangeVersion workflow #6209

Closed bowenxia closed 1 month ago

bowenxia commented 1 month ago

What changed?

  1. The workflowCount is not a int type, which caused errors in Mono repo. Simply change the casting would resolve this error.
  2. The Pinot query for CadenceChangeVersion workflow has a small bug, deleted the AS clause in GroupBy fixed it.

Why? Testing analyzer in mono repo.

How did you test it? Unit test, manual test. Staging test results:

Screenshot 2024-08-07 at 12 30 11 PM Screenshot 2024-08-07 at 12 30 22 PM

Potential risks

Release notes

Documentation Changes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.94%. Comparing base (c77db73) to head (1eb59d8).

Additional details and impacted files | [Files](https://app.codecov.io/gh/uber/cadence/pull/6209?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [...rker/esanalyzer/domainWorkflowTypeCountWorkflow.go](https://app.codecov.io/gh/uber/cadence/pull/6209?src=pr&el=tree&filepath=service%2Fworker%2Fesanalyzer%2FdomainWorkflowTypeCountWorkflow.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS93b3JrZXIvZXNhbmFseXplci9kb21haW5Xb3JrZmxvd1R5cGVDb3VudFdvcmtmbG93Lmdv) | `83.23% <100.00%> (+0.30%)` | :arrow_up: | | [service/worker/esanalyzer/workflow.go](https://app.codecov.io/gh/uber/cadence/pull/6209?src=pr&el=tree&filepath=service%2Fworker%2Fesanalyzer%2Fworkflow.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-c2VydmljZS93b3JrZXIvZXNhbmFseXplci93b3JrZmxvdy5nbw==) | `90.08% <100.00%> (+0.26%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/uber/cadence/pull/6209/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/uber/cadence/pull/6209?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/uber/cadence/pull/6209?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Last update [c77db73...1eb59d8](https://app.codecov.io/gh/uber/cadence/pull/6209?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber).