uber / causalml

Uplift modeling and causal inference with machine learning algorithms
Other
4.87k stars 756 forks source link

Support the latest scikit-learn #682

Closed jeongyoonlee closed 8 months ago

jeongyoonlee commented 9 months ago

Is your feature request related to a problem? Please describe.

Current causal tree implementation depends on scikit-learn<=1.0.2, and it raises Cython errors with the latest scikit-learn due to the change introduced in scikit-learn/scikit-learn#22328.

Describe the solution you'd like

Updating the caudal tree code with the changes in scikit-learn/scikit-learn#22328.

Describe alternatives you've considered

Adding scikit-learn/scikit-learn/tree as a subtree (ref). This may help better sync the causalml and scikit-learn's tree implementations while allowing the usage of the latest scikit-learn.

Additional context N/A

ras44 commented 9 months ago

see also discussion in #619

jeongyoonlee commented 8 months ago

Resolved with #686