uber / causalml

Uplift modeling and causal inference with machine learning algorithms
Other
4.87k stars 756 forks source link

fix stratified sampling call #756

Closed IanDelbridge closed 2 months ago

IanDelbridge commented 3 months ago

Proposed changes

Fixes https://github.com/uber/causalml/issues/755 (never actually using stratified sampling because of an incorrect call to scikit-learn's train_test_split).

Types of changes

What types of changes does your code introduce to CausalML? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.