return_ci=True argument is not passed in the get_ate_ci method of Sensitivity class object and running sensitivity_analysis gives a ValueError for a Tlearner object. Adding return_ci=True to the get_ate_ci method with another nested try/except layer since not all estimate_ate methods of learners that is to be run in get_ate_ci method of Sensitivity take the return_ci argument.
Types of changes
What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.
Proposed changes
Issue 757
return_ci=True
argument is not passed in theget_ate_ci
method ofSensitivity
class object and runningsensitivity_analysis
gives aValueError
for a Tlearner object. Addingreturn_ci=True
to theget_ate_ci
method with another nested try/except layer since not allestimate_ate
methods of learners that is to be run inget_ate_ci
method ofSensitivity
take thereturn_ci
argument.Types of changes
What types of changes does your code introduce to CausalML? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.