Fix two MacOS bugs - Githubissues

uber / cyborg

Display Android Vectordrawables on iOS.

Apache License 2.0

302 stars 19 forks source link

Fix two MacOS bugs #81

Closed benpious closed 4 years ago

benpious commented 4 years ago

There were two bugs left open after @ashare80's pr adding MacOS support was merged:

the layers weren't laid out after the drawable was set. I can't recall if invalidateIntrinsicContentSize() was there before I made that comment, so I'm gonna add a needsLayout = true call to make sure
NSColors need to be manually converted to the right color space before calling getRed(blue: green: alpha:) or they will assert.

This pr addresses both those issues.

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}