uber / h3-js

h3-js provides a JavaScript version of H3, a hexagon-based geospatial indexing system.
https://uber.github.io/h3
Apache License 2.0
875 stars 79 forks source link

Upgrade to v4.0.0-rc2 (take two) #139

Closed nrabinowitz closed 2 years ago

nrabinowitz commented 2 years ago

Supersedes #136

@isaacbrodsky and I agreed that I should take on the subsequent work on his PR, and with separate forks the easiest option was to open a new PR with his commits + my commits. For the most part, my commits cover my own code review comments on the previous PR.

Summary of my additional changes:

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2631277174


Totals Coverage Status
Change from base Build 2543820363: 0.0%
Covered Lines: 510
Relevant Lines: 510

💛 - Coveralls
nrabinowitz commented 2 years ago

Note that the renaming of distance here should probably wait for https://github.com/uber/h3/pull/622 to be resolved

nrabinowitz commented 2 years ago

Note that the renaming of distance here should probably wait for uber/h3#622 to be resolved

Actually, I walked this back in the JS code - we can update with the next release candidate.