Closed nrabinowitz closed 2 years ago
Totals | |
---|---|
Change from base Build 2543820363: | 0.0% |
Covered Lines: | 510 |
Relevant Lines: | 510 |
Note that the renaming of distance
here should probably wait for https://github.com/uber/h3/pull/622 to be resolved
Note that the renaming of
distance
here should probably wait for uber/h3#622 to be resolved
Actually, I walked this back in the JS code - we can update with the next release candidate.
Supersedes #136
@isaacbrodsky and I agreed that I should take on the subsequent work on his PR, and with separate forks the easiest option was to open a new PR with his commits + my commits. For the most part, my commits cover my own code review comments on the previous PR.
Summary of my additional changes:
int64
values as JS 64-bit floats (confirmed this appears precise up toMAX_SAFE_INTEGER
)