search

uber / ios-snapshot-test-case

Snapshot view unit tests for iOS
MIT License
1.79k stars 211 forks source link

Adds Bazel Support V2 #155

Closed tinder-maxwellelliott closed 3 years ago

tinder-maxwellelliott commented 3 years ago

Also updates CI to run Bazel tests

alanzeino commented 3 years ago

Very cool! We might have to modify build.sh to install bazel before the job can run, let's see if it is installed on these mac runners that github provides

alanzeino commented 3 years ago 
  File "/private/var/tmp/_bazel_runner/9332cfebedfd62170f1b5b8776e50dc1/sandbox/darwin-sandbox/21/execroot/__main__/bazel-out/darwin-fastbuild/bin/FBSnapshotTestCaseTests/FBSnapshotTestCaseTests.runfiles/xctestrunner/shared/plist_util.py", line 244, in _GetPlistLibModule
    plistlib.readPlist(plist_file_path)
AttributeError: module 'plistlib' has no attribute 'readPlist'

maybe we're missing something the testrunner expects, like a dependency on plistlib installed via pip and on the PATH, possibly we can just add that to the build.sh

https://github.com/google/xctestrunner/blob/master/shared/plist_util.py#L44