search

uber / mockolo

Efficient Mock Generator for Swift
Apache License 2.0
813 stars 86 forks source link

Support `some` parameter's handler #213

Closed fummicc1 closed 1 year ago

fummicc1 commented 1 year ago

I added new property isOpaqueType to take care of some keyword placed at paramter.

After this fix

source mock
Screenshot 2023-02-07 at 0 29 26 Screenshot 2023-02-07 at 0 29 20
uhooi commented 1 year ago

@fummicc1 thx for PR!! I would like you to write a unit test :pray:

fummicc1 commented 1 year ago

@uhooi

Thanks for quick reply!

I tried to add two unit tests for my fixes.

fummicc1 commented 1 year ago

@sidepelican Thank you!

I corrected them as you mentioned. (I found one more thing to be fixed. I will send a review request later)

fummicc1 commented 1 year ago

@uhooi Hello~ I would like you to review this PR when you have available time.

uhooi commented 1 year ago

@fummicc1 Granted write roll. Feel free to cut a new tag/release (see the past ones for example); make sure to bump the version first at https://github.com/uber/mockolo/blob/master/Sources/MockoloFramework/Version.swift (e.g. 1.8.0 -> 1.8.1)