search

uber / mockolo

Efficient Mock Generator for Swift
Apache License 2.0
804 stars 85 forks source link

Update swift-syntax to 509.0.0 #247

Closed pablocornejo closed 4 months ago

pablocornejo commented 9 months ago

The codebase is being updated to work with swift-syntax 509.0.0

uhooi commented 9 months ago

@rudro plz merge :)

pablocornejo commented 4 months ago

Hello @sidepelican @uhooi, is there something else required so that this can be merged?

sidepelican commented 4 months ago

We are already not maintainers and do not have the authority to merge.

According to https://github.com/uber/mockolo/issues/220, @rudro @alanzeino seems to be the maintainer, but I haven't seen much of them.

alanzeino commented 4 months ago

Sorry, I assumed you could still merge. Let me check the permissions.

alanzeino commented 4 months ago

@sidepelican can you show me what message you see on your end? I've double checked our branch protection rules and you should be able to merge as you have write permissions, along with @uhooi

Screenshot 2024-02-13 at 19 10 50

The only thing I can't really tell is if Uber has an organization global protection rule that doesn't allow non–Uber employees to merge PRs. I'll have to get back to you on that. For now, I'll merge this.

In future if you at–mention me I can merge until we resolve this.

uhooi commented 4 months ago

@alanzeino The following message will be displayed:

You’re not authorized to merge this pull request.

image
sidepelican commented 4 months ago

Same.

alanzeino commented 4 months ago

Updated the Branch protection rule settings, should work now.

uhooi commented 4 months ago

@alanzeino thx!! I can't select "Create a merge commit", can I just "Squash and merge"?

image
alanzeino commented 4 months ago

I also changed that; to match other projects at Uber.