search

uber / nanoscope

An extremely accurate Android method tracing tool.
Apache License 2.0
1.25k stars 68 forks source link

#51/fix open requirements #52

Closed FredLoh closed 6 years ago

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Leland-Takamine commented 6 years ago

Thanks for the contribution @FredLoh. Would you mind squashing your commits?

FredLoh commented 6 years ago

I think you can squash them when you merge? Happy to make the change if that's not the case. It's been a while since I used github's PR features.

Leland-Takamine commented 6 years ago

Yes - it's possible to squash when merging but it ends up polluting the commit history in a different way so we've disabled that functionality for this repo. Instead, we always use "Rebase and merge" and manage our commit history locally.

FredLoh commented 6 years ago

Ah, makes sense, will squash. Thanks!