search

uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl
https://nebula.gl/
Other
689 stars 165 forks source link

react-map-gl-draw: removing positions from feature in EditingMode #393

Open kludcev opened 4 years ago

kludcev commented 4 years ago

By using EditingMode I can change feature shape, add new positions, move feature, but I can't remove positions from a feature - onUpdate doesn't fire. By using ModifyMode from @nebula.gl/edit-modes I can remove positions. Is there any possibility to do both without switching between EditingMode and ModifyMode?

Codesandbox example https://codesandbox.io/s/empty-framework-72m4q?file=/src/App.js

xintongxia commented 4 years ago

It is on my list, will work on refactor EditingMode of react-map-gl-draw and leverage the ModifyMode of nebula.gl/edit-modes.

peetjvv commented 4 years ago

Are there any updates on this? I just started using react-map-gl-draw and are really lacking a feature to remove positions along a LineString (although I'm sure all multi-position features could use this feature)

bianzbenny commented 4 years ago

Anywhere to explain the difference of nebula.gl/edit-modes and editingmode of react-map-gl-draw? kind of being lost when looking at mode api doc and react-map-gl-draw api doc. What is the relationship between these two? Does react-map-gl-draw require map-box GL? My use cases don't need a moving map (maybe a static map as background.

llpons commented 4 years ago

Here a pull request implementing this feature: https://github.com/uber/nebula.gl/pull/433