uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl
https://nebula.gl/
Other
688 stars 166 forks source link

React Map GL Draw - initial features not editable #648

Open Kieran-Lynn opened 2 years ago

Kieran-Lynn commented 2 years ago

Describe the bug

When supplying features to the features prop with the editor mode, they are no longer editable

This has been brought up and fixed before but its broken again https://github.com/uber/nebula.gl/issues/274 https://github.com/uber/nebula.gl/issues/295

Actual Result

You can add vertices to polygons but cannot drag them around

Expected Result

You should be able to edit vertices

Reproduce Steps

This sandbox was provided by @xintongxia to show it working, All you have to do is update the dependency in the sandbox project to the latest version to see it break. https://codesandbox.io/s/react-map-gl-draw-with-initial-features-m0e97?file=/src/App.js

Screenshots

To Do List

sharathprabhal commented 2 years ago

Same issue here

maxnowack commented 2 years ago

This might be a duplicate of uber/nebula.gl#580. so maybe a downgrade to 0.21.1 is a workaround in the meantime.

cubecleveland commented 2 years ago

HI guys, Was that ever resolved. Any one knows ehat is the latest stable version that can give us basics functioanlity ?

igorDykhta commented 2 years ago

@cubecleveland I've assigned the issue to myself. Before switching to EditableGeojsonLayer we used "react-map-gl-draw": "0.14.8".

cubecleveland commented 2 years ago

Thanks so much, as ive said we are swithcing form the leaflet impleentation.

We have no issue to move to deck Gl. are u saying that it is better to switch completely to use Deck Gl and nebula and leave the react map gl implementation? Is there any working simple version i can tap into?

igorDykhta commented 2 years ago

@cubecleveland We switched to EditableGeojsonLayer in order to get more flexibility with events. Both modules should be very similar, but EditableGeojsonLayer requires more setup and extra logic.

examples/editor examples/react-map-gl-draw