search

uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl
https://nebula.gl/
Other
691 stars 165 forks source link

fix scripts to work crossplatform #823

Closed vkozio closed 1 year ago

vkozio commented 1 year ago

fixes for build scripts to work on Windows

ibgreen commented 1 year ago

Thanks for contributing. I have mixed feelings about this change.

While Uber has not yet contributed nebula.gl to the OpenJS foundation, nebula.gl is effectively a key extension frameworks in the bigger deck.gl / vis.gl ecosystem which is under open governance.

As part of that ecosystem, one goal of the maintainers is to work towards a similar structure on repositories and build tools etc, so that maintainers can move with comfort between the repos.

Since very few deck.gl / vis.gl contributors work on Windows, so for Windows development, we have focused on supporting the WSL environment (see e.g. https://loaders.gl/docs/developer-guide/dev-env#environment-setup) rather than trying to use cross-platform tools.

No one among the core contributors can really test and maintain these cross platform tools on Windows, and I don't see us adding such cross platform tooling to other repos, so I worry that having this here won't be helpful to the team long term, as it represents an additional abstraction to learn and maintain.

Komzpa commented 1 year ago

I see two options here.

  1. Add this change, and similar one to all of vis.gl too. This would require writing also some doc on how to build it under native Windows too. Probably not perfect.

  2. Get the chunk of documentation about development environment ported over to nebula.gl repos, so that such confusion does not happen anymore. Maybe add a "get yourself a WSL" warning.

@ibgreen @igorDykhta do I get right we're leaning towards 2 here?

ibgreen commented 1 year ago

@Komzpa Yes, #2 would seem more likely to stay "maintained", as the tooling used on mac / linux should then still work on WSL.

I'd love to see that loaders.gl Windows developer page moved up into the common visgl developer-process, at least as a recommendation for the frameworks, but Windows development is not the highest priority for the TSC.

ibgreen commented 1 year ago

And yes, we'd definitely accept PRs that fix issues under WSL.

ibgreen commented 1 year ago

@Komzpa If your team is planning to stepping up as the core maintainer of nebula.gl, then you would also get to be decision makers in how the repo should be structured, and it would ultimately be your call how to support Windows dev.

What I am saying is that while I value alignment between the repos, I’d rather have a strong maintainer for nebula.gl, at the cost of some divergence.

Alternatively: if not merging this makes you less likely to contribute, then that is a good reason to merge it.

Akiyamka commented 1 year ago

We have decided that we are not going to measure it yet