search

uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl
https://nebula.gl/
Other
691 stars 165 forks source link

fix: Fix to fire the finishMovePosition state at the end of a feature… #828

Closed giuseppe-straziota closed 1 year ago

giuseppe-straziota commented 1 year ago

During the editing mode, the state called finishMovePosition is never fired, I found out that the problem was derived by a mistyped call to an object property and to a comparison between strings, in particular with the constant ELEMENT_TYPE.FEATURE that in my case has a capital letter differently from what is defined in the code, for this reason, I added a call to toLowerCase function to the switch because of the many places where the constant is used.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

igorDykhta commented 1 year ago

@giuseppe-straziota Hi, could you sign Contributor License Agreement?

giuseppe-straziota commented 1 year ago

Hi @igorDykhta happy to be useful to the project. I signed but seems it's still pending.

igorDykhta commented 1 year ago

@giuseppe-straziota you should sign with the correct email/account.

giuseppestraziota seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

giuseppe-straziota commented 1 year ago

Now seems ok, thanks for the help