uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl
https://nebula.gl/
Other
689 stars 165 forks source link

Adds onCancelPan optional prop and adds more calls to cancelPan #887

Open alex-bain opened 1 year ago

alex-bain commented 1 year ago

Hello - thank you for building NebulaGL, it is a fantastic library.

This PR contains two small changes:

  1. Introduces an optional onCancelPan prop to editable-layer, allowing developers to execute their own logic when NebulaGL determines a map panning operation should be interrupted
  2. Adds event.cancelPan() invocations for additional EditModes to ensure event.cancelPan is always being called at the appropriate time
CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ibgreen commented 1 year ago

Thanks for opening this. In particular, appreciate that docs were added. Testing interactive functions is tricky, but it possible to add a test case or two?

ibgreen commented 12 months ago

@igorDykhta If possible let's see if we can help @alex-bain land this

@chennney