feat: add `DrawLineStringByDraggingMode` ("Pencil" mode)

uber / nebula.gl

A suite of 3D-enabled data editing overlays, suitable for deck.gl

https://nebula.gl/

Other

686 stars 166 forks source link

feat: add `DrawLineStringByDraggingMode` ("Pencil" mode) #897

Open ben-xD opened 6 months ago

ben-xD commented 6 months ago

I implemented this for https://geojsons.com/, it's used by the pencil tool

https://github.com/uber/nebula.gl/assets/24711048/4c5e8067-3d29-45d8-9110-2ba14af6aee7

I believe that is also what https://github.com/uber/nebula.gl/issues/172 requested, but we got the (also very useful) DrawPolygonByDraggingMode

In the example app

PS: I still need to get things building in nebula.gl and then try this out in the example app.

https://github.com/uber/nebula.gl/assets/24711048/45f97582-4c67-4a7b-8765-331ada635a10

CLAassistant commented 6 months ago

All committers have signed the CLA.

ben-xD commented 6 months ago

Cool 😺️,

what's new updated in 06c8dfe17b0fe5a8ee00a741a0eddd7d7ec01d6f
2 tests added in 6818bc9ca4ebc67fae9fb58071ad4862cb986004

ibgreen commented 6 months ago

Erm, I just realized that we no longer have write access to this repository, meaning I can't merge your PR. I am afraid that the plan is to move nebula.gl code over to a new @deck.gl-community/editable-layers module in the deck.gl-community repo, then we could reapply this PR.

ben-xD commented 6 months ago

No worries, looking forward to a deck.gl community package! I'm happy to re-open it there :)