uber / neuropod

A uniform interface to run deep learning models from multiple frameworks

https://neuropod.ai

Apache License 2.0

936 stars 77 forks source link

Fix a bug with loading large models (> 2gb) #544

Closed VivekPanyam closed 2 years ago

VivekPanyam commented 2 years ago

Summary:

The zipfile library we were previously using had trouble with files larger than ~2gb (the max value of an int32). This broke loading of large models. This PR modifies Neuropod to use a different zip library and also adds a test to ensure we can package and load large models correctly.

Test Plan:

New test that packages and loads a large (~3gb) TorchScript model + CI

codecov[bot] commented 2 years ago

Codecov Report

Merging #544 (1d3c46c) into master (1d3c46c) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 1d3c46c differs from pull request most recent head 182afee. Consider uploading reports for the commit 182afee to get more accurate results

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files         105      105           
  Lines        7002     7002           
=======================================
  Hits         6066     6066           
  Misses        936      936

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d3c46c...182afee. Read the comment docs.