uber / orbit

A Python package for Bayesian forecasting with object-oriented design and probabilistic models under the hood.
https://orbit-ml.readthedocs.io/en/stable/
Other
1.85k stars 132 forks source link

Fix cmdstanpy install issue with pip #847

Closed swotai closed 6 months ago

swotai commented 6 months ago

Description

In Windows using the windows store's python distributions and venv, installation of the package would break during installation of cmdStan and creation of the complied stan binaries. This is caused by usage of temp folder, having to move things around from temp to package directory, as well as missing complier in Windows.

Fix: Simplified setup.py workflow by aligning installing workflow with non-window machines. Adds complier=True flag to cmdstanpy.install_cmdstan. Tested on python 3.9-3.11 venvs.

Fixes #808

Type of change

How Has This Been Tested?

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.