search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.8k stars 284 forks source link

Fix spurious legacy-regex rule warning #495

Closed selitvin closed 4 years ago

selitvin commented 4 years ago

The warning was occuring when both legacy and the new rule produced the same overall set of fields, but maybe in different order. Although, both rules would behave the same from the user perspective, they would see a warning. The warning would be bogus because it wouldn't contain any field names.

codecov[bot] commented 4 years ago

Codecov Report

Merging #495 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files          79       79           
  Lines        4190     4190           
  Branches      665      665           
=======================================
  Hits         3594     3594           
  Misses        494      494           
  Partials      102      102
Impacted Files Coverage Δ
petastorm/unischema.py 94.58% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b85d13a...6e53b41. Read the comment docs.