search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Raising an error if an empty list of columns is selected by a user #615

Closed selitvin closed 3 years ago

selitvin commented 3 years ago

Makes it easier to detect user logic error, as it makes no sense to create a reader that loads no data from storage.

codecov[bot] commented 3 years ago

Codecov Report

Merging #615 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          87       87           
  Lines        4994     4996    +2     
  Branches      795      796    +1     
=======================================
+ Hits         4279     4281    +2     
  Misses        578      578           
  Partials      137      137
Impacted Files Coverage Δ
petastorm/reader.py 90.33% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2889a05...be5d52c. Read the comment docs.