search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.8k stars 284 forks source link

Remove implementation of __getattr__ for UniSchema #655

Open v01dXYZ opened 3 years ago

v01dXYZ commented 3 years ago

Hello, I found a very minor issue (probably a typo): https://github.com/uber/petastorm/blob/d6f4e82eb2c3a6c2b4c16c060c7350331b60a51a/petastorm/unischema.py#L355-L356 This is not really required (basically since we don't reimplement __getattribute__, that will always be object.__getattribute__(obj, item) that will be invoked when we getattr).

selitvin commented 3 years ago

Thanks for the report. Will clean it up (or feel free to submit a fix in a PR :) ).