search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.8k stars 284 forks source link

Remove Unischema __getattr__ implementation #656

Open v01dXYZ opened 3 years ago

v01dXYZ commented 3 years ago

This MR solves #655.

It removes the implementation of the fallback Unischema.__getattr__ which doesn't seem to add any value.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: selitvin
:x: v01dXYZ
You have signed the CLA already but the status is still pending? Let us recheck it.

selitvin commented 3 years ago

I see that the build is broken for some unrelated reason. Fixing it.