search

uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.78k stars 285 forks source link

Extraction of storage_options from URL #694

Closed manjuransari-zz closed 3 years ago

manjuransari-zz commented 3 years ago

PR for issue #691

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

manjuransari-zz commented 3 years ago

@selitvin can you please review the changes.

manjuransari-zz commented 3 years ago

@selitvin can you review and approve the running workflows. It says first time contributor need maintainer to approve.

selitvin commented 3 years ago

Seems like flake8 fails. Not sure why is that. Will try looking at it today or tomorrow - unless you know what's going on?

manjuransari-zz commented 3 years ago

Don't know why the flake8 fails.

selitvin commented 3 years ago

Trying to fix flake8 failure here: #701.

codecov[bot] commented 3 years ago

Codecov Report

Merging #694 (fab66a9) into master (b39302b) will increase coverage by 0.01%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   86.16%   86.18%   +0.01%     
==========================================
  Files          84       84              
  Lines        5045     5051       +6     
  Branches      788      788              
==========================================
+ Hits         4347     4353       +6     
  Misses        559      559              
  Partials      139      139
Impacted Files Coverage Δ
petastorm/fs_utils.py 92.04% <90.00%> (+0.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b39302b...fab66a9. Read the comment docs.

manjuransari-zz commented 3 years ago

@selitvin build/test complete. Waiting for merge.