uber / petastorm

Petastorm library enables single machine or distributed training and evaluation of deep learning models from datasets in Apache Parquet format. It supports ML frameworks such as Tensorflow, Pytorch, and PySpark and can be used from pure Python code.
Apache License 2.0
1.76k stars 281 forks source link

Add missing field_name in ValueError #792

Open chasleslr opened 1 year ago

chasleslr commented 1 year ago

I encountered this error a few times and noticed the variable name was missing. Without this commit, the error currently reads:

Field {} is not "nullable", but got passes a None value
CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Charles Lariviere seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

selitvin commented 1 year ago

Thanks for the fix! So we can land your change, can you please accept the CLA?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0b0775a) 86.24% compared to head (b808fc1) 86.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #792 +/- ## ======================================= Coverage 86.24% 86.24% ======================================= Files 84 84 Lines 5090 5090 Branches 790 790 ======================================= Hits 4390 4390 Misses 560 560 Partials 140 140 ``` | [Impacted Files](https://codecov.io/gh/uber/petastorm/pull/792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber) | Coverage Δ | | |---|---|---| | [petastorm/unischema.py](https://codecov.io/gh/uber/petastorm/pull/792?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber#diff-cGV0YXN0b3JtL3VuaXNjaGVtYS5weQ==) | `93.30% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uber)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.