search

uber / prototool

Your Swiss Army Knife for Protocol Buffers
MIT License
5.04k stars 345 forks source link

Add protoc-gen-mypy to Docker image #524

Closed juzna closed 4 years ago

juzna commented 4 years ago

The mypy compiler (https://github.com/dropbox/mypy-protobuf/) generates typing information, which is very useful for IDEs and static analysis.

Also upgrading to newest versions of dependencies in Alpine in separate commit, because pinned versions are not available anymore, so the image can't be built currently.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

smaye81 commented 4 years ago

Thank for being patient on this. If you are still interested in this PR, can you rebase dev and update any outdated deps in the Dockerfile? If not, I can just close the PR.

smaye81 commented 4 years ago

Closing. If this is still needed, let's discuss. We'd prefer just building your own image off of uber/prototool anyway.

juzna commented 4 years ago

Yes, we ended up using our own protool image. I just thought that mypy is so generic that it would be useful to many.

smaye81 commented 4 years ago

Nice, I'm glad you were able to work it out. Thanks for putting up the original PR, though. Glad you found a solution.