uber / prototool

Your Swiss Army Knife for Protocol Buffers
MIT License
5.05k stars 345 forks source link

Add walk-timeout command line flag #545

Closed smaye81 closed 4 years ago

smaye81 commented 4 years ago

Adds a walk-timeout flag to certain commands that involve walking the directory structure.

If no walk-timeout is specified where applicable, 3 seconds (3s) will be used as the default which is the current default. Therefore, this maintains backwards compatibility with current walk timeout and allows users to override at a command-level.

Fixes #516

codecov[bot] commented 4 years ago

Codecov Report

Merging #545 into dev will increase coverage by 0.16%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #545      +/-   ##
==========================================
+ Coverage   66.09%   66.26%   +0.16%     
==========================================
  Files         144      144              
  Lines        7462     7490      +28     
==========================================
+ Hits         4932     4963      +31     
+ Misses       2023     2019       -4     
- Partials      507      508       +1     
Impacted Files Coverage Δ
internal/file/file.go 100.00% <ø> (+10.00%) :arrow_up:
internal/cmd/templates.go 84.08% <90.90%> (+0.48%) :arrow_up:
internal/cmd/flags.go 100.00% <100.00%> (ø)
internal/exec/exec.go 73.52% <100.00%> (+2.56%) :arrow_up:
internal/exec/runner.go 53.25% <100.00%> (+0.05%) :arrow_up:
internal/file/proto_set_provider.go 69.94% <100.00%> (+1.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd23eea...b78e68c. Read the comment docs.