search

uber / prototool

Your Swiss Army Knife for Protocol Buffers
MIT License
5.05k stars 345 forks source link

Add ability to annotate messages/fields with nolint directive #547

Open jared2501 opened 4 years ago

jared2501 commented 4 years ago

I have some enums/structs that fail lint in my protobuf, for good reason (e.g. I have an enum called X509_KEY_USAGE_DATA_ENCIPHERMENT, and "data encipherment is a phrase taken from IETF spec).

Currently, i skip the entire file by adding it to my prototool.yaml. Instead, I would like to be able to annotate this enum, or even this value in the enum, with a comment that would disable linting for this specific case. golangci-lint offers a // nolint:<rule-name> directive which I find super handy in cases like these. Can prototool learn this skill too?

smaye81 commented 4 years ago

Yeah this is a fair request. I will add it to the backlog.

sysulq commented 2 years ago

looking forward to this new feature！